Fix ufl cell vs basix cell#615
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #615 +/- ##
========================================
Coverage 96.97% 96.98%
========================================
Files 13 13
Lines 397 398 +1
========================================
+ Hits 385 386 +1
Misses 12 12
☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
added
the
fenicsx
Collaborator
|
Could update this in the test/benchmark.py file too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is a small PR to anticipate the future deprecation of
ufl.FiniteElementand uses basix instead.Also modifies the permeation test to avoid dividing by zero.
Overall reduces the number of warnings in the tests.