Settings and Stepsize classes#616
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #616 +/- ##
===========================================
+ Coverage 96.98% 97.47% +0.48%
===========================================
Files 13 16 +3
Lines 398 475 +77
===========================================
+ Hits 386 463 +77
Misses 12 12
☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
requested changes
Oct 19, 2023
Collaborator
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
First round of comments
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
RemDelaporteMathurin
requested changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
With this change, users can directly alter the parameters of the solver: the absolute and relative tolerance, the maximum iterations and final time of a transient simulations. The stepsize will be defined in its own class stepsize as this will likely evolve to something very similar to festim in its current version (v0.11.0). Stepsize will be an attribute of F.Settings.
Usage:
and for stepsize:
Additional solver modifications can be made after the initialisation of the simulation for more niche cases:
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...