Henry's boundary conditions#637
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #637 +/- ##
===========================================
+ Coverage 98.50% 98.68% +0.17%
===========================================
Files 18 19 +1
Lines 738 761 +23
===========================================
+ Hits 727 751 +24
+ Misses 11 10 -1
☔ View full report in Codecov by Sentry. |
jhdark
reviewed
Nov 9, 2023
Co-authored-by: James Dark <65899899+jhdark@users.noreply.github.com>
jhdark
reviewed
Nov 9, 2023
jhdark
approved these changes
Nov 9, 2023
Collaborator
jhdark
left a comment
jhdark
left a comment
There was a problem hiding this comment.
Looks great to me, thanks @gabriele-ferrero for the contribution!
RemDelaporteMathurin
approved these changes
Nov 9, 2023
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Thanks @gabriele-ferrero !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...