Skip to content

Tests for reactions 2#639

Merged
RemDelaporteMathurin merged 3 commits into
festim-dev:reactions-in-formulationfrom
jhdark:tests_for_reactions_2
Nov 14, 2023
Merged

Tests for reactions 2#639
RemDelaporteMathurin merged 3 commits into
festim-dev:reactions-in-formulationfrom
jhdark:tests_for_reactions_2

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Nov 14, 2023

Proposed changes

Adding some tests for the new reactions class

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef4a396) 98.19% compared to head (591b9ad) 98.23%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           reactions-in-formulation     #639      +/-   ##
============================================================
+ Coverage                     98.19%   98.23%   +0.03%     
============================================================
  Files                            20       20              
  Lines                           888      904      +16     
============================================================
+ Hits                            872      888      +16     
  Misses                           16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

@jhdark is this ready to merge?

@jhdark
Copy link
Copy Markdown
Collaborator Author

jhdark commented Nov 14, 2023

@jhdark is this ready to merge?

Yep

@RemDelaporteMathurin RemDelaporteMathurin merged commit 9059eb0 into festim-dev:reactions-in-formulation Nov 14, 2023
@jhdark jhdark deleted the tests_for_reactions_2 branch November 14, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants