Skip to content

Use dolfinx v0.7.0 in CI#658

Merged
RemDelaporteMathurin merged 3 commits into
festim-dev:fenicsxfrom
jhdark:update_CI_dolfinx_version
Dec 3, 2023
Merged

Use dolfinx v0.7.0 in CI#658
RemDelaporteMathurin merged 3 commits into
festim-dev:fenicsxfrom
jhdark:update_CI_dolfinx_version

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Dec 2, 2023

Proposed changes

fix for issue #600

With this change, all the tests on the CI will be done using dolfinx v0.7.0 which we are using locally, can be updated once we we to use a newer updated version

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3227dd3) 98.44% compared to head (732f84e) 98.44%.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #658   +/-   ##
========================================
  Coverage    98.44%   98.44%           
========================================
  Files           23       23           
  Lines          964      964           
========================================
  Hits           949      949           
  Misses          15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhdark jhdark marked this pull request as ready for review December 2, 2023 22:45
@jhdark jhdark linked an issue Dec 2, 2023 that may be closed by this pull request
@RemDelaporteMathurin RemDelaporteMathurin merged commit 7a18957 into festim-dev:fenicsx Dec 3, 2023
@RemDelaporteMathurin RemDelaporteMathurin added the fenicsx Issue that is related to the fenicsx support label Jan 23, 2024
@jhdark jhdark deleted the update_CI_dolfinx_version branch March 3, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fenicsx Issue that is related to the fenicsx support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to pin a specific version for dolfinx in CI

2 participants