Reaction.product now accepts a list of Species

[RemDelaporteMathurin]

Proposed changes

This PR fixes #702 by allowing users to give a list of Species for the product of a Reaction.

This gives us the ability to implement reactions of the type:

A + B <-> C + D

Need to merge #703 first since the tests use some of the functionality....

Types of changes

What types of changes does your code introduce to FESTIM?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code refactoring
• Documentation Update (if none of the other choices apply)
• New tests

Checklist

• Black formatted
• Unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (be788e4) to head (1cc4673).

Additional details and impacted files

@@             Coverage Diff             @@
##           fenicsx     #704      +/-   ##
===========================================
+ Coverage    99.05%   99.15%   +0.09%     
===========================================
  Files           26       26              
  Lines         1168     1183      +15     
===========================================
+ Hits          1157     1173      +16     
+ Misses          11       10       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RemDelaporteMathurin]

@jhdark this is now ready for review

[jhdark]

This looks great to me, just some small suggestions but not necessary changes

[jhdark]

Does this need its own file or can it go into the test_reaction file?

[RemDelaporteMathurin]

I'd rather keep it seperate for now to 1) avoid super long files 2) keep things seperated until we have a discussion on how to organise tests

[jhdark]

Would it be worth adding another test where we have A -> B + C?

[RemDelaporteMathurin]

This kind of reaction is currently not implemented