Skip to content

MMS testing #721

Merged
RemDelaporteMathurin merged 4 commits into
festim-dev:fenicsxfrom
jhdark:new_mms_testing
Mar 27, 2024
Merged

MMS testing #721
RemDelaporteMathurin merged 4 commits into
festim-dev:fenicsxfrom
jhdark:new_mms_testing

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Mar 27, 2024

Proposed changes

MMS testing! This PR starts to build up an MMS testing suite for vigorous verification testing. I've adapted the tests in fenicsx tutorial.

This PR provides the first version of how system tests can be implemented in fenicsx, however a more sophisticated infrastructure of MMS testing will be implemented in the future!

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jhdark jhdark added enhancement New feature or request fenicsx Issue that is related to the fenicsx support labels Mar 27, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (ec46ff2) to head (0ba836b).

Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #721      +/-   ##
===========================================
+ Coverage    99.15%   99.24%   +0.08%     
===========================================
  Files           26       26              
  Lines         1183     1185       +2     
===========================================
+ Hits          1173     1176       +3     
+ Misses          10        9       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. We will have to work on homogenising the MMS testing architecture later

@RemDelaporteMathurin RemDelaporteMathurin merged commit 82d5d6e into festim-dev:fenicsx Mar 27, 2024
@jhdark jhdark deleted the new_mms_testing branch March 3, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fenicsx Issue that is related to the fenicsx support

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants