Arbitrary reaction#730
Merged
RemDelaporteMathurin merged 39 commits intoMay 17, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #730 +/- ##
===========================================
- Coverage 98.39% 98.39% -0.01%
===========================================
Files 27 28 +1
Lines 1437 1554 +117
===========================================
+ Hits 1414 1529 +115
- Misses 23 25 +2 ☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
requested changes
Apr 3, 2024
Collaborator
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Hi @Allentro thanks for this! This will bring more flexibility to Reactions.
I have a couple of initial comments
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
RemDelaporteMathurin
requested changes
Apr 4, 2024
RemDelaporteMathurin
requested changes
Apr 4, 2024
Collaborator
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
@Allentro here are a few suggestions:
- make p_0 and E_p optional arguments defaulting to
None - test that 1) if a product is given, p_0 and E_p are not None, and 2) that if no product is given, p_0 and E_p are None.
RemDelaporteMathurin
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enabled an arbitrary number of reactants and products. This resolves #720
I've enabled it so that The number of products can be 0 for radioactive decay (A -> None), but the number of reactants must be at least length 1.
Types of changes
Checklist