Remove Source for ParticleSource#732
Merged
RemDelaporteMathurin merged 1 commit intoApr 4, 2024
Merged
Conversation
RemDelaporteMathurin
added
the
fenicsx
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #732 +/- ##
===========================================
- Coverage 98.39% 98.39% -0.01%
===========================================
Files 27 27
Lines 1437 1434 -3
===========================================
- Hits 1414 1411 -3
Misses 23 23 ☔ View full report in Codecov by Sentry. |
jhdark
approved these changes
Apr 4, 2024
Collaborator
jhdark
left a comment
jhdark
left a comment
There was a problem hiding this comment.
Looks good, made the previous PR much more manageable without all these changes too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #686 this removes
Sourcein favour ofParticleSource