fenicsx: Flux BC support#737
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #737 +/- ##
===========================================
+ Coverage 98.39% 98.51% +0.12%
===========================================
Files 27 28 +1
Lines 1434 1554 +120
===========================================
+ Hits 1411 1531 +120
Misses 23 23 ☔ View full report in Codecov by Sentry. |
| if self.value is None: | ||
| return False |
There was a problem hiding this comment.
Isn't this a bit dangerous? Say I check if it's time-dependent before assigning it a value by mistake, I may think it's not time-dpeendent but then it becomes time dependent if the value is say a function of time.
Should we raise an error instead?
There was a problem hiding this comment.
Yeah this is valid, but would be worth changing the other cases of this property in other classes too
There was a problem hiding this comment.
Opened an issue to track progress on this #744
| Args: | ||
| t (float): the time | ||
| """ | ||
| if callable(self.value): |
There was a problem hiding this comment.
Is this needed? I would replace by if self.time_dependent? what if it isn't? should we raise an error? or just a print?
There was a problem hiding this comment.
This is how we also handle it in sources, and Dirichlet bc, so maybe we could change this for all of them in another PR?
There was a problem hiding this comment.
Sounds good with me
|
@jhdark just a couple of documentation changes and then I think we are good to go with this one. We will later add concentration dependent (Robin) |
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Proposed changes
With this change, users will be able to impose flux boundary conditions:
Users can implement this like:
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...