Simplify custom tagging of meshes#755
Merged
RemDelaporteMathurin merged 18 commits intoJun 17, 2024
Merged
Conversation
RemDelaporteMathurin
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #755 +/- ##
===========================================
+ Coverage 98.39% 98.90% +0.51%
===========================================
Files 28 28
Lines 1554 1550 -4
===========================================
+ Hits 1529 1533 +4
+ Misses 25 17 -8 ☔ View full report in Codecov by Sentry. |
jhdark
requested changes
Apr 30, 2024
Collaborator
jhdark
left a comment
jhdark
left a comment
There was a problem hiding this comment.
Looks great, simplifying H transport problem too, just needs some additional coverage
Comment on lines
-151
to
-163
|
|
||
|
|
||
| def test_surface_setter_raises_TypeError(): | ||
| """Test that a TypeError is raised when the surface is not a | ||
| F.SurfaceSubdomain1D""" | ||
|
|
||
| with pytest.raises( | ||
| TypeError, match="surface should be an int or F.SurfaceSubdomain1D" | ||
| ): | ||
| F.SurfaceQuantity( | ||
| field=F.Species("H"), | ||
| surface="1", | ||
| ) |
Collaborator
There was a problem hiding this comment.
This test just needs changing rather than deleting to improve the coverage
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR brings some simplification in subdomains:
Mesh1DtoMeshto make it more genericSurfaceSubdomainandVolumeSubdomainrespectively.An example of how this simplifies a lot of things is the refactoring of the system tests!
@jhdark an additional simplification would be to enable users to provide a geometrical locator function when defining a subdomain (instead of creating a custom class). What do you think?
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist