tqdm.auto instead of tqdm.autonotebook + refresh#759
Merged
RemDelaporteMathurin merged 2 commits intoApr 22, 2024
Conversation
RemDelaporteMathurin
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #759 +/- ##
========================================
Coverage 98.49% 98.49%
========================================
Files 28 28
Lines 1532 1533 +1
========================================
+ Hits 1509 1510 +1
Misses 23 23 ☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
changed the title
tqdm.auto instead of tqdm.autonotebooktqdm.auto instead of tqdm.autonotebook + refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when running in notebooks there was a bunch of warnings from tqdm.
After a bit of reading (jmcarpenter2/swifter#67) I switched
autonotebooktoautoand that got rid of the warning.Also, the progress bar in notebooks is slick!
I also added a refresh call after the timestepping loop to make sure the bar displays 100% (and even still sometimes it doesn't work...)