Skip to content

added possibility to not display the progress bar#879

Merged
RemDelaporteMathurin merged 3 commits into
fenicsxfrom
progress-bar-optional
Aug 30, 2024
Merged

added possibility to not display the progress bar#879
RemDelaporteMathurin merged 3 commits into
fenicsxfrom
progress-bar-optional

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

Proposed changes

I've had issues with tqdm recently as it messes up the profiling of scripts somehow... This just adds a flag to turn it off.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (02a374f) to head (348183b).
Report is 247 commits behind head on fenicsx.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #879   +/-   ##
========================================
  Coverage    98.92%   98.92%           
========================================
  Files           36       36           
  Lines         1580     1584    +4     
========================================
+ Hits          1563     1567    +4     
  Misses          17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin added the fenicsx Issue that is related to the fenicsx support label Aug 29, 2024
@RemDelaporteMathurin RemDelaporteMathurin added the enhancement New feature or request label Aug 29, 2024
@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator Author

Merging after discussions on slack

@RemDelaporteMathurin RemDelaporteMathurin merged commit 77c97b3 into fenicsx Aug 30, 2024
@RemDelaporteMathurin RemDelaporteMathurin deleted the progress-bar-optional branch August 30, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fenicsx Issue that is related to the fenicsx support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant