Various fixes#894
Merged
Merged
Conversation
…a git account is not needed for latest updates of the code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #894 +/- ##
========================================
Coverage 97.75% 97.76%
========================================
Files 44 44
Lines 2098 2099 +1
========================================
+ Hits 2051 2052 +1
Misses 47 47 ☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
approved these changes
Oct 12, 2024
Collaborator
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Thanks @kaelyndunnell for this contribution! You modified the fenicsx branch, however we would like to see this documentation change (what do I need to know) on main too
Could you open another PR to add this change to the main branch too please?
RemDelaporteMathurin
requested changes
Oct 24, 2024
This was
linked to
issues
Oct 24, 2024
RemDelaporteMathurin
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist