Skip to content

Allows tolerances to be callable#958

Merged
jhdark merged 21 commits into
festim-dev:fenicsxfrom
kaelyndunnell:callable-tols
Mar 11, 2025
Merged

Allows tolerances to be callable#958
jhdark merged 21 commits into
festim-dev:fenicsxfrom
kaelyndunnell:callable-tols

Conversation

@kaelyndunnell
Copy link
Copy Markdown
Contributor

@kaelyndunnell kaelyndunnell commented Mar 3, 2025

Proposed changes

Allows tolerances to be callable (not just an integer or float). Solves callable and returns a float before passing tolerance to fenicsx.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (01ab7f9) to head (ceae144).
Report is 290 commits behind head on fenicsx.

Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #958      +/-   ##
===========================================
+ Coverage    96.02%   96.15%   +0.13%     
===========================================
  Files           45       46       +1     
  Lines         2490     2575      +85     
===========================================
+ Hits          2391     2476      +85     
  Misses          99       99              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Kaelyn! Just a couple of suggestions to make this better

Comment thread src/festim/problem.py
Comment thread src/festim/problem.py Outdated
Comment thread test/test_settings.py Outdated
Comment thread src/festim/problem.py
@RemDelaporteMathurin RemDelaporteMathurin added enhancement New feature or request fenicsx Issue that is related to the fenicsx support labels Mar 4, 2025
@jhdark jhdark merged commit 0573b74 into festim-dev:fenicsx Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fenicsx Issue that is related to the fenicsx support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants