1D mesh parallelisation#964
Merged
RemDelaporteMathurin merged 8 commits intoMar 12, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #964 +/- ##
========================================
Coverage 96.08% 96.09%
========================================
Files 46 46
Lines 2608 2611 +3
========================================
+ Hits 2506 2509 +3
Misses 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+44
to
+46
| else: | ||
| mesh_points = np.empty((0, 1), dtype=np.float64) | ||
| cells = np.empty((0, 2), dtype=np.int64) |
Collaborator
There was a problem hiding this comment.
Can we try and test this using ipyparrallel?
RemDelaporteMathurin
approved these changes
Mar 12, 2025
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Looks like we can't get the coverage up even when testing with ipyparallel
RemDelaporteMathurin
approved these changes
Mar 12, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This small fix allows for 1D meshes to be created in parallel
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...