Skip to content

use temporary directory for exports#968

Merged
jhdark merged 5 commits into
festim-dev:fenicsxfrom
jhdark:tmpdir-exports-in-tests
Mar 11, 2025
Merged

use temporary directory for exports#968
jhdark merged 5 commits into
festim-dev:fenicsxfrom
jhdark:tmpdir-exports-in-tests

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Mar 11, 2025

Proposed changes

With this change exports in the tests will be passed into a temporary directory rather than exporting locally. Reducing the number of files generated in the local space.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (0573b74) to head (ab8dc46).
Report is 201 commits behind head on fenicsx.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #968   +/-   ##
========================================
  Coverage    96.08%   96.08%           
========================================
  Files           46       46           
  Lines         2608     2608           
========================================
  Hits          2506     2506           
  Misses         102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread test/benchmark.py
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use pytest and tmpdir?

@jhdark jhdark merged commit 7217618 into festim-dev:fenicsx Mar 11, 2025
@jhdark jhdark deleted the tmpdir-exports-in-tests branch March 11, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants