Pulsed mb#12
Merged
Merged
Conversation
RemDelaporteMathurin
requested changes
Oct 15, 2024
Collaborator
There was a problem hiding this comment.
You need to add matplotlib as a conda dependency. This is what is making the Ci fail. Here, matplotlib is installed alongside HTM as a pip package. This conflicts with dolfinx which is installed with Conda.
(hello @shimwell)
Collaborator
Author
wautert
pushed a commit
to wautert/hisp
that referenced
this pull request
May 10, 2026
FIxed bugs regarding maximum allowed timesteps and implementing new exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added pulses fluxes and temperatures. Integrated with DINA data. Added recombination BC on surface.