Scenario framework#25
Merged
Merged
Conversation
…mes for temperature & ion fluxes. Model crashing at 34%
…lper function for pulsing
Adding CI
Fix import issue with HTM
…ould later fix .dat files to be standardized and thus this commit with be undone
… correctly. festim simu creating a jump in concentration at close of pulse that should not be there. adjusted filename in ci
…cies now in ICWC pulse, to be fixed in new branch
This was
linked to
issues
Oct 30, 2024
…ch row of scenario file
…or multiple pulses, subtracting the time of the elapsed pulses from the float(t) % operator to determine if the pulse is on/off).
This was referenced Oct 31, 2024
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
This was referenced Oct 31, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CI & testing, built multi-pulse capability as in issue #13, made consistent material values as in issue #19, fixed FENICS error that is soon to be fixed in FESTIM (issue #18).