Refactor for RISP#31
Merged
Merged
Conversation
Update install instructions in README
Better `Scenario` class
…g old format scenario
New class to treat DINA files
Collaborator
Author
|
@kaelyndunnell CI finally passes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major refactoring of the current structure:
hisp.make_mb_modelfunction that returns a festim model and parameterises things like temperature, particle fluxes, length of MB, final time of sim. It is also possible to modify anything in the festim model after calling this function.dinathat contains all the dina functionsheat,RISP_dataandget_particle_flux. The idea is that we may have other submodules for other tools (eg. SOLPS)PlasmaDataHandlingclass that will take all the data for different pulses and RISP data files (will be refactored later)