Refactoring#53
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
src/hisp/festim_models/mb_model.py:758
- [nitpick] The function name 'T_function_W_pure' is not very descriptive. Consider renaming it to 'calculate_temperature_W'.
def T_function_W_pure(x, heat_flux, coolant_temp, thickness):
src/hisp/festim_models/mb_model.py:766
- [nitpick] The function name 'T_function_B_pure' is not very descriptive. Consider renaming it to 'calculate_temperature_B'.
def T_function_B_pure(heat_flux, coolant_temp):
kaelyndunnell
approved these changes
Nov 25, 2024
Collaborator
kaelyndunnell
left a comment
kaelyndunnell
left a comment
There was a problem hiding this comment.
Looks great! Note to self that will follow this same model for the ion and atom implantation ranges implementation.
kaelyndunnell
requested changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides refactoring for the temperature and particle fluxes functions.
I did not provide tests at this stage and will keep it for another PR as I suspect a new class will be created for this