Fix RISP_data function#58
Merged
Merged
Conversation
…risp pulses. assigned them a value & update example to test
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
I see how this fixes the bug. Though could you write a test to prove that the fix is effective?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, RISP_data function assigned flux values only to first wall sub bins and divertor bins that were on the inner and outer strike point. This means that the function broke when a Divbin on neither the inner or outer strike point was passed to RISP_data.
Added capability to return correct RISP flux data for non-strike point Divbins. Note that this is a "quick fix" that relies on the offset_mb function, which should eventually be changed in accordance with issue #50.
Updates all_bin_scenario example to test an outer strike point and non-strike point Divbin.