Refactor running all bins#65
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
examples/all_bin_scenario.py:123
- The variable 'sub_bin' should be renamed to 'bin' to match the rest of the function.
folder=f"mb{parent_bin_index+1}_{sub_bin.mode}_results",
examples/all_bin_scenario.py:139
- [nitpick] The word 'FESTIM' should be 'festim' to match the naming convention used in the rest of the code.
Runs the FESTIM model for the given bin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #64 to be merged before merging this.
Refactors the all_bin_scenario example. First step towards shipping all this to
hisp