Skip to content

Add surface area calculations to the subbins#71

Merged
RemDelaporteMathurin merged 2 commits into
mainfrom
surface-area-subbins
Dec 21, 2024
Merged

Add surface area calculations to the subbins#71
RemDelaporteMathurin merged 2 commits into
mainfrom
surface-area-subbins

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

No description provided.

@RemDelaporteMathurin RemDelaporteMathurin marked this pull request as ready for review December 20, 2024 15:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread src/hisp/bin.py
Copy link
Copy Markdown
Collaborator

@kaelyndunnell kaelyndunnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- note to future self could later add similar calculation to DivBin class.

@RemDelaporteMathurin RemDelaporteMathurin merged commit 3c4b1d9 into main Dec 21, 2024
@RemDelaporteMathurin RemDelaporteMathurin deleted the surface-area-subbins branch February 4, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants