Skip to content

Cap stepsize differently for RISP#75

Merged
kaelyndunnell merged 11 commits into
mainfrom
max_stepsize_for_RISP
Jan 14, 2025
Merged

Cap stepsize differently for RISP#75
kaelyndunnell merged 11 commits into
mainfrom
max_stepsize_for_RISP

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Dec 30, 2024

This pull request includes several modifications to the src/hisp/festim_models/mb_model.py, src/hisp/model.py, and test/test_mb_model_festim.py files. These changes primarily focus on updating model settings, refining mesh vertices, and enhancing the handling of specific pulse types in the model. Additionally, the test cases have been updated to reflect these changes. The most important changes are summarized below:

Model Settings and Mesh Refinement:

Pulse Handling Enhancements:

  • src/hisp/model.py: Added special handling for "RISP" pulses in the max_stepsize method, including setting specific step sizes and milestones for real RISP pulses. [1] [2]

Test Case Updates:

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link
Copy Markdown
Collaborator

@kaelyndunnell kaelyndunnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: should we add another test later with high fluxes?

@kaelyndunnell kaelyndunnell merged commit ac6fc0e into main Jan 14, 2025
@kaelyndunnell kaelyndunnell deleted the max_stepsize_for_RISP branch January 14, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants