Cap stepsize differently for RISP#75
Merged
Merged
Conversation
kaelyndunnell
approved these changes
Jan 14, 2025
Collaborator
kaelyndunnell
left a comment
There was a problem hiding this comment.
note to self: should we add another test later with high fluxes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several modifications to the
src/hisp/festim_models/mb_model.py,src/hisp/model.py, andtest/test_mb_model_festim.pyfiles. These changes primarily focus on updating model settings, refining mesh vertices, and enhancing the handling of specific pulse types in the model. Additionally, the test cases have been updated to reflect these changes. The most important changes are summarized below:Model Settings and Mesh Refinement:
src/hisp/festim_models/mb_model.py: Updated themax_iterationsto 30 and adjusted theatolandrtolvalues for various model creation functions (make_W_mb_model,make_B_mb_model,make_DFW_mb_model). [1] [2] [3] [4]Pulse Handling Enhancements:
src/hisp/model.py: Added special handling for "RISP" pulses in themax_stepsizemethod, including setting specific step sizes and milestones for real RISP pulses. [1] [2]Test Case Updates:
test/test_mb_model_festim.py: Updated the test cases for different models (test_mb_W_model,test_mb_model_B,test_mb_model_DFW) to use a higher temperature value and set the initial step size value. [1] [2] [3] [4] [5] [6]