Remove error when time overshoots maximum time#77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve error handling and add a new test case. The most important changes include modifying the
get_rowmethod insrc/hisp/scenario.pyto use a warning instead of raising an error, and adding a new test case intest/test_mb_model_festim.pyto check for model overshoot at the last timestep.Error handling improvements:
src/hisp/scenario.py: Changed theget_rowmethod to issue aUserWarninginstead of raising aValueErrorwhen the timetis out of bounds. This allows the method to return a value even when the time is out of bounds.Testing enhancements:
test/test_mb_model_festim.py: Added a new test casetest_model_last_timestep_overshootto verify the behavior of the model when the last timestep overshoots. This test case initializes a scenario and model, sets the model parameters, and checks the iteration process.