Loop cases for prodloss SUBDD setup#116
Merged
joewallwork merged 4 commits intoprodloss-fields-subddfrom Apr 1, 2025
Merged
Conversation
joewallwork
added
enhancement
joewallwork
force-pushed
the
111_prodloss-loops
branch
from
695b9aa to
03c8a8f
Compare
joewallwork
force-pushed
the
111_prodloss-loops
branch
from
03c8a8f to
50916b5
Compare
AdelekeBankole
approved these changes
Mar 31, 2025
joewallwork
added a commit
that referenced
this pull request
Apr 1, 2025
* add units for prodloss fields * define prodloss 3d fields * hook up prodloss 3d fields * Loop cases for prodloss SUBDD setup (#116) * Convert Model E -> GEOS-Chem transfers to TODOs * Use valid derived type; loop over products and losses * Loops over products and losses for data transfer --------- Co-authored-by: Joe Wallwork <jw2423@cam.ac.uk> Co-authored-by: Adeleke Bankole <ab3191@login-q-2.data.cluster>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #111.
Merges into #114.
This PR sets up the loop cases for products and losses. It also provides some corrections:
ProdLossis not a valid derived type - it should beState_Diag.State_Diagderived type are invalid. The changes here replace them with TODO notes because we don't currently know what the arrays are called in the GISS Model.