Hook up other SUBDD-State_Diag for 2D StateMet tracers#98
Merged
joewallwork merged 4 commits intohistory-rc-file-for-model-efrom Mar 14, 2025
Merged
Hook up other SUBDD-State_Diag for 2D StateMet tracers#98joewallwork merged 4 commits intohistory-rc-file-for-model-efrom
StateMet tracers#98joewallwork merged 4 commits intohistory-rc-file-for-model-efrom
Conversation
joewallwork
changed the title
StateMet fieldsStateMet tracers
joewallwork
force-pushed
the
29_subdd-statediag
branch
from
fb139f3 to
2168e27
Compare
joewallwork
force-pushed
the
29_subdd-statediag
branch
from
2168e27 to
f7dbbf4
Compare
joewallwork
force-pushed
the
29_subdd-statediag
branch
from
f7dbbf4 to
f0bb79a
Compare
joewallwork
commented
Mar 14, 2025
| endif | ||
|
|
||
| if ( trim(subdd%name(k)) == "StateMet_SUNCOSMID" ) then | ||
| if ( trim(subdd%name(k)) == "StateMet_SUNCOSmid" ) then |
Collaborator
Author
There was a problem hiding this comment.
It's formatted this way in the HISTORY file.
joewallwork
commented
Mar 14, 2025
Comment on lines
+4064
to
+4065
| sname = 'StateMet_USTAR', & | ||
| lname = 'StateMet_USTAR', & |
Collaborator
Author
There was a problem hiding this comment.
This was just a typo introduced by me.
joewallwork
commented
Mar 14, 2025
Comment on lines
+3753
to
+3759
| #ifdef MODEL_GEOS | ||
| arr(next()) = info_type_( & | ||
| sname = 'StateMet_CNVFRC', & | ||
| lname = 'StateMet_CNVFRC', & | ||
| units = '1' & | ||
| ) | ||
| #endif |
Collaborator
Author
There was a problem hiding this comment.
This was just a missing preprocessor statement by me.
joewallwork
commented
Mar 14, 2025
Comment on lines
-212
to
-219
| ! TODO: Which array? | ||
| ! State_Met%AD (II,JJ) = ??? | ||
|
|
||
| ! TODO: Which array? | ||
| ! State_Met%AIRDEN (II,JJ) = ??? | ||
|
|
||
| ! TODO: Which array? | ||
| ! State_Met%AIRVOL (II,JJ) = ??? |
Collaborator
Author
There was a problem hiding this comment.
It turns out these are actually 3D arrays so should be handled separately.
AdelekeBankole
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #29.
Merges into #84.
This PR hooks up the other 2D
StateMetfields that weren't already considered.