Conversation
added 3 commits
November 16, 2024 14:26
Upgrade minimum Go version to 1.22 to allow upgrading to the latest etcd version, which requires 1.22 . Also update all other direct dependencies.
Add cobra argument parsing to concentratorconfig and etcdconfigweb to show the available configuration options to the user. Also allow changing some hardcoded values/paths using command line arguments.
Test the IP address and subnet generation to avoid breaking the existing generation when updating or refactoring it. Given that the subnet generation uses some binary operations, it is hard to spot potential errors. For this usecase the function generating the subnet was externalized to be accessible from the test code instead of an inlined function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all dependencies. This also required changing the minimum Go version to 1.22 due to etcd.
The
concentratorconfigandetcdconfigwebcommands now supports command line flags to change some hardcoded settings like file paths.Also added a test for the IP range and address generation to prevent regressions on code refactorings (related to freifunkMUC/etcd-tools#1 )