fix(my-timezone): Set ntpclient dependency version to '*'#1238
Merged
Conversation
Agent-Logs-Url: https://github.com/ffflorian/node-packages/sessions/cf851528-c815-420c-b482-75760f68fad2 Co-authored-by: ffflorian <5497598+ffflorian@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ffflorian/node-packages/sessions/cf851528-c815-420c-b482-75760f68fad2 Co-authored-by: ffflorian <5497598+ffflorian@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ffflorian
May 22, 2026 01:30
View session
ffflorian
changed the title
ntpclient in my-timezone to unblock release versioning
github-actions Bot
pushed a commit
that referenced
this pull request
May 22, 2026
## [1.15.4](https://github.com/ffflorian/node-packages/compare/my-timezone@1.15.3...my-timezone@1.15.4) (2026-05-22) ### Bug Fixes * **deps:** bump vite from 8.0.13 to 8.0.14 ([#1235](#1235)) ([e0ab600](e0ab600)) * **my-timezone:** Coordinate parsing regex ([#1237](#1237)) ([a03592c](a03592c)) * **my-timezone:** Set ntpclient dependency version to '*' ([#1238](#1238)) ([baea54f](baea54f)) * Use Node 26 ([b8918e0](b8918e0))
github-actions Bot
pushed a commit
that referenced
this pull request
May 22, 2026
## [3.16.2](https://github.com/ffflorian/node-packages/compare/scrabble-cheater@3.16.1...scrabble-cheater@3.16.2) (2026-05-22) ### Bug Fixes * **deps:** bump vite from 8.0.13 to 8.0.14 ([#1235](#1235)) ([e0ab600](e0ab600)) * **my-timezone:** clarify solar time semantics and fix stale API names ([#1158](#1158)) ([828c91b](828c91b)) * **my-timezone:** Coordinate parsing regex ([#1237](#1237)) ([a03592c](a03592c)) * **my-timezone:** Make latitude optional ([9438ac2](9438ac2)) * **my-timezone:** Set ntpclient dependency version to '*' ([#1238](#1238)) ([baea54f](baea54f)) * **ntfy:** add markdown header support ([#1135](#1135)) [ci skip] ([f28279c](f28279c)) * **ntfy:** Use stringified boolean value ([ea43165](ea43165)) * Use Node 26 ([b8918e0](b8918e0))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a release-versioning mismatch where
my-timezonedepended on a fixedntpclientversion, which can break publish flow whenntpclientis being bumped in the same release cycle. It aligns the dependency with the monorepo release convention for internal packages.Problem addressed
packages/my-timezone/package.jsonreferencedntpclientvia an exact published version (1.16.1), creating coupling to npm availability during semantic-release version bumps.Change made
my-timezone->ntpclientdependency from a fixed version to the internal workspace placeholder ("*"), so release tooling can resolve and rewrite versions consistently.Lockfile alignment
yarn.lockentries to reflectntpclient@npm:*resolution formy-timezone.{ "dependencies": { "commander": "14.0.3", "ntpclient": "*" } }