Open
Conversation
jimen0
reviewed
Nov 9, 2020
Co-authored-by: M. Ángel Jimeno <jimen0@users.noreply.github.com>
|
i think it will be nice to see this feature in ffuf, any expected timelines ? |
shelld3v
approved these changes
Jan 9, 2021
|
Bump. This would be a very nice addition! |
joohoi
requested changes
May 14, 2021
Member
joohoi
left a comment
joohoi
left a comment
There was a problem hiding this comment.
Cheers @pry0cc !
As we spoke OOB, this PR was on hold due to the need of making the progress bar smaller before we can add new stuff to it.
I was running some tests on other stuff, and realized that we can easily make space for the percentage status indicator by removing the Progress: - text from the beginning of the line. The end result would look something like:
:: [1142/20473] 51% :: Job [1/1] :: 671 req/sec :: Duration: [0:00:05] :: Errors: 0 ::
What do you think?
Before this can be merged though, I'd love you to add your name to CONTRIBUTORS.md and a short description of the change to CHANGELOG.md.
Author
|
YES! That sounds fantastic!!!!! ❤️🔥 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm not sure if there was a specific reason you didn't add a progress percentage, but I felt it was useful for my personal use. Feel free to deny this, although I am curious!
Fixes: My impatient mind