Fix large list bytecode estimation by removing sampling#113
Merged
Conversation
- Remove sampling from LargeNodeRefactorer.shouldRefactor() * Was estimating only 10 elements out of thousands * Now estimates all elements for accurate size calculation * 2,576-element list now correctly estimated at 85,465 bytes (vs 31,684) - Fix BytecodeSizeEstimator to use proper visitor pattern * ListNode adds only list overhead (5 bytes per element) * StringNode fixed to 6 bytes (LDC + INVOKESTATIC) based on disassembly * Elements estimate themselves via visit() - no special cases * Added constant pool overhead for large lists - Remove experimental codegen-time refactoring * Refactoring happens only at parse time as designed * Cleaned up all debug trace statements Result: Large lists (2,576+ elements) now correctly refactored into chunks at parse time, preventing JVM 'Method too large' errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ExifTool's
%Image::ExifTool::Extrahash (2,576 elements) was causing "Method too large" JVM errors.Root cause: Bytecode size estimation was using sampling (only 10 elements) instead of estimating all elements, leading to severe underestimation: 31,684 bytes estimated vs actual >65KB.
Solution
1. Removed Sampling from
LargeNodeRefactorer.shouldRefactor()2. Fixed
BytecodeSizeEstimatorfor Proper Visitor Patternvisit()- no special cases or multipliers3. Code Cleanup
EmitLiteral.javaResult