Skip to content

Fix jcpan to install .pl files alongside .pm files #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fglock merged 2 commits into from
Mar 25, 2026
Merged

Fix jcpan to install .pl files alongside .pm files #376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b268fb
Fix jcpan to install .pl files alongside .pm files
fglock Mar 25, 2026
0272b98
Merge origin/master into fix/jcpan-exiftool-writer-pl
fglock Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/perl/lib/ExtUtils/MakeMaker.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,12 @@ sub _install_pure_perl {
}
} else {
# Default: scan lib/ directory
# Include both .pm and .pl files (some modules like Image::ExifTool
# use .pl files loaded via require)
if (-d 'lib') {
find({
wanted => sub {
return unless -f && /\.pm$/;
return unless -f && /\.p[lm]$/;
my $src = $File::Find::name;
(my $rel = $src) =~ s{^lib/}{};
$pm{$src} = File::Spec->catfile($INSTALL_BASE, $rel);
Expand All @@ -211,7 +213,7 @@ sub _install_pure_perl {
if (-d 'blib/lib') {
find({
wanted => sub {
return unless -f && /\.pm$/;
return unless -f && /\.p[lm]$/;
my $src = $File::Find::name;
(my $rel = $src) =~ s{^blib/lib/}{};
$pm{$src} = File::Spec->catfile($INSTALL_BASE, $rel);
Expand All @@ -222,7 +224,7 @@ sub _install_pure_perl {
}

if (!%pm) {
print "Warning: No .pm files found to install.\n";
print "Warning: No .pm or .pl files found to install.\n";
print "Expected structure: lib/Your/Module.pm\n\n";
return PerlOnJava::MM::Installed->new($args);
}
Expand Down
Loading