fix: materialize local arrays and hashes before return#386
Merged
Conversation
When returning localized arrays or hashes from subroutines, the values must be copied before local restoration occurs. Without this fix, returning `local @ARGV` would return ARRAY references to the restored (original) values instead of the localized values. Extended materializeSpecialVarsInResult() to copy RuntimeArray and RuntimeHash elements before local restoration happens. Fixes Module::Build test failures where args() method returned ARGV references to restored values. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When returning localized arrays or hashes from subroutines, the values must be copied before local restoration occurs. Without this fix, returning
local @ARGVwould return ARRAY references to the restored (original) values instead of the localized values.materializeSpecialVarsInResult()to copyRuntimeArrayandRuntimeHashelements before local restoration happensProblem
This was blocking Module::Build test suite where the
args()method uses this pattern.Test plan
make test)local.tGenerated with Devin