fix: delete $::{'Pkg::'} now properly removes namespace symbols#427
Merged
Conversation
When deleting a stash namespace entry (key ending with '::'),
RuntimeStash.deleteGlob() was a no-op because it computed
fullKey = 'main::Foo::' but symbols are stored as 'Foo::bar'.
The exact-key lookup found nothing and returned early.
Fix: detect namespace keys and perform prefix-based removal from
all global maps (globalCodeRefs, globalVariables, globalArrays,
globalHashes, globalIORefs, globalFormatRefs) plus pinnedCodeRefs.
This fixes spurious 'Subroutine ACTION_foo redefined' warnings in
Module::Build t/help.t, and makes Foo->can('bar') correctly
return false after delete $::{'Foo::'}.
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
de47b68 to
045f7ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete $::{'Foo::'}was a complete no-op becauseRuntimeStash.deleteGlob()computedfullKey = "main::Foo::"but symbols are stored as"Foo::bar"(without themain::prefix). The exact-key lookup found nothing and returned early.deleteNamespace()method inRuntimeStash: When the key ends with::, performs prefix-based removal from all 6 global maps (globalCodeRefs,globalVariables,globalArrays,globalHashes,globalIORefs,globalFormatRefs)clearPinnedCodeRefsForNamespace()inGlobalVariable: Prevents deleted subs from being resurrected bygetGlobalCodeRef()lookups (which re-inserts frompinnedCodeRefs)Before
After
This fixes spurious
Subroutine ACTION_foo redefinedwarnings in Module::Build'st/help.ttest, which callsdelete($::{'MyModuleBuilder::'})between test blocks to clean up the namespace.Test plan
Foo->can('bar')returns false afterdelete $::{'Foo::'}makepasses (all unit tests)Generated with Devin