Skip to content

fix: add _charnames.pm patch to sync.pl#460

Merged
fglock merged 3 commits into
masterfrom
feature/charnames-sync-patch
Apr 8, 2026
Merged

fix: add _charnames.pm patch to sync.pl#460
fglock merged 3 commits into
masterfrom
feature/charnames-sync-patch

Conversation

@fglock
Copy link
Copy Markdown
Owner

@fglock fglock commented Apr 8, 2026

Summary

  • Add _charnames.pm.patch to dev/import-perl5/patches/ so sync.pl preserves PerlOnJava-specific patches
  • Add patch reference in config.yaml

Patches preserved:

  1. populate_txt fallback: When unicore/Name.pl is unavailable, sets $txt to a truthy placeholder instead of crashing
  2. viacode ICU4J lookup: Falls back to _java_viacode() for Unicode name lookups using Java ICU4J library

These patches were being lost on every sync.pl run, requiring manual restoration.

Test plan

  • make passes
  • perl dev/import-perl5/sync.pl applies patch cleanly

Generated with Devin

fglock and others added 3 commits April 8, 2026 09:44
Restored two PerlOnJava-specific patches that sync.pl overwrote:
1. populate_txt: fallback when unicore/Name.pl unavailable
2. viacode: ICU4J-backed _java_viacode() lookup

Added _charnames.pm.patch and config.yaml patch reference so future
sync.pl runs preserve these changes automatically.

Generated with [Devin](https://cli.devin.ai/docs)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Run dev/import-perl5/sync.pl to update core modules:
- Pod::Simple 3.45 version bump across all submodules
- Pod::Simple::XHTML: new accessibility features
- Pod::perlhack.pod, Pod::perlsyn.pod: documentation updates
- English.pm: minor update

Generated with [Devin](https://cli.devin.ai/docs)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Run Configure.pl --upgrade to update dependencies.

Generated with [Devin](https://cli.devin.ai/docs)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@fglock fglock merged commit c8b84dc into master Apr 8, 2026
2 checks passed
@fglock fglock deleted the feature/charnames-sync-patch branch April 8, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant