Fix 'no strict refs' not being honored in hash/array dereferences #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that Dereference.handleArrowHashDeref() and handleArrowArrayDeref()
were not checking the HINT_STRICT_REFS flag at compile time. They always used
the strict versions of dereference methods, even when 'no strict refs' was active.
Changes:
- RuntimeScalar.java: Added 8 new *NonStrict methods for hash/array operations
(hashDerefDeleteNonStrict, hashDerefExistsNonStrict, arrayDerefGetNonStrict,
arrayDerefDeleteNonStrict, arrayDerefExistsNonStrict, arrayDerefGetSliceNonStrict)
- RuntimeBaseProxy.java: Added 6 NonStrict method overrides to delegate to lvalue
- Dereference.java: Updated handleArrowHashDeref() and handleArrowArrayDeref()
to check isStrictOptionEnabled(HINT_STRICT_REFS) and call appropriate methods
Test Results:
- t/op/multideref.t: Now passes 56/65 tests (was 2/65)
- The first 3 strict refs tests now pass
- Remaining failures are unrelated (local/autovivification issues)
Fixes symbolic references like: $a[0]{k} where $a[0] = 'foo' creates $foo{k}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that Dereference.handleArrowHashDeref() and handleArrowArrayDeref() were not checking the HINT_STRICT_REFS flag at compile time. They always used the strict versions of dereference methods, even when 'no strict refs' was active.
Changes:
RuntimeScalar.java: Added 8 new *NonStrict methods for hash/array operations (hashDerefDeleteNonStrict, hashDerefExistsNonStrict, arrayDerefGetNonStrict, arrayDerefDeleteNonStrict, arrayDerefExistsNonStrict, arrayDerefGetSliceNonStrict)
RuntimeBaseProxy.java: Added 6 NonStrict method overrides to delegate to lvalue
Dereference.java: Updated handleArrowHashDeref() and handleArrowArrayDeref() to check isStrictOptionEnabled(HINT_STRICT_REFS) and call appropriate methods
Test Results:
Fixes symbolic references like: $a[0]{k} where $a[0] = 'foo' creates $foo{k}