fix: handle use vN; (single-component v-string version)#640
Merged
Conversation
`use v5;` (as in Future::Queue's Build.PL) crashed with `Index 1 out of bounds for length 1` because StatementParser assumed the normalized version always had at least major.minor parts. For single-component v-strings normalizeVersion returns just "5", so parts[1] threw. Default minor version to 0 when only one component is present. Verified: `./jcpan -t Future::Queue` now passes (36/36 tests). Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Index 1 out of bounds for length 1crash when parsinguse vN;(single-component v-string version declaration).Future::Queue-0.52'sBuild.PLstarts withuse v5;, which broke./jcpan -t Future::Queue.StatementParser.parseUseDeclarationdidInteger.parseInt(parts[1])after splitting the normalized version on., but for a single-component v-string (v5)normalizeVersionreturns just"5", soparts[1]threw.The fix defaults
minorVersionto0when only one component is present.Test plan
make(full unit test suite passes)./jcpan -t Future::Queuenow passes all 36 tests across 7 test filesGenerated with Devin