fix(dev/tools): reliable parallel perl_test_runner JSON handoff#731
Open
fglock wants to merge 1 commit into
Open
fix(dev/tools): reliable parallel perl_test_runner JSON handoff#731fglock wants to merge 1 commit into
fglock wants to merge 1 commit into
Conversation
…d PID Parallel runs globbed /tmp/perl_test_* and matched on test_file, which could associate the wrong child output under load — logs showed phantom failures (exec.t incomplete TAP, unrelated comp regressions). Write each child's summary to /tmp/perl_test_runner_RESULT_<PID>; parent reads exactly that path when waitpid reap fires. Generated with [Cursor](https://cursor.com/docs) Co-Authored-By: Cursor <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Parallel
perl_test_runner.plusedglob(\"/tmp/perl_test_*\")and scanned JSON blobs untiltest_filematched the reaped worker. Under concurrent JVM load this can correlate the wrong child result with the wrong.t, producing bogus lines in saved logs (I 27/41forop/exec.t, phantom✗oncomp/tests).Fix
Every child writes its summary JSON to
/tmp/perl_test_runner_result_<PID>; the parent, which knowschild_pidfromwaitpid, reads only that path. No shared glob scan.Verification