Fix File::ShareDir::Install test failures#758
Merged
Conversation
- Use $(INST_LIB) and $(INST_ARCHLIB) variables instead of hardcoded blib/lib and blib/arch paths - Make config:: target depend on pm_to_blib so postamble rules are executed - Add command to copy share files from blib to install directory during make install - Fix _build_share_file_mapping to filter dot directories based on dotdirs setting using File::Find preprocess callback
- Add stub methods (oneliner, split_command, quote_literal) to make File::ShareDir::Install's postamble work correctly - Fix PREFIX handling to set INSTALLSITELIB using $(SITEPREFIX) as a variable in the Makefile - Add SITEPREFIX variable to the Makefile when provided - Fix install command to properly copy share files from $(INST_LIB)/auto/share to $(INSTALLSITELIB)/auto/share - All File::ShareDir::Install tests now pass (39/39 subtests)
- Change to perl5/t/ directory for tests in perl5/t/ so they can find ./test.pl via require - Fixes false positive regressions in mro/next_NEXT.t and mro/next_NEXT_utf8.t - Both tests now pass (4/4 each)
- Change to perl5_t/t/ directory for tests in perl5_t/t/ so they can find ./test.pl via require - Fixes false positive regressions in mro/next_NEXT.t and mro/next_NEXT_utf8.t - Both tests now pass (4/4 each)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix File::ShareDir::Install test failures by:
This resolves test failures in t/10_makefile.t and t/11_dotfile.t.