Skip to content

fix: Signature adapter#343

Merged
fgmacedo merged 2 commits intodevelopfrom
macedo/fix-dispatcher-with-default-values
Jan 29, 2023
Merged

fix: Signature adapter#343
fgmacedo merged 2 commits intodevelopfrom
macedo/fix-dispatcher-with-default-values

Conversation

@fgmacedo
Copy link
Copy Markdown
Owner

@fgmacedo fgmacedo commented Jan 29, 2023

  • Closes #341: Fix dynamic dispatch on methods with default parameters.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e14b8e8) compared to base (f1afe5a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        18    +1     
  Lines          800       862   +62     
  Branches       112       120    +8     
=========================================
+ Hits           800       862   +62     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
statemachine/dispatcher.py 100.00% <100.00%> (ø)
statemachine/signature.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fgmacedo fgmacedo changed the title feat: Testing signature adapter (with failing test cases) fix: Signature adapter Jan 29, 2023
@fgmacedo fgmacedo marked this pull request as ready for review January 29, 2023 05:14
@fgmacedo fgmacedo force-pushed the macedo/fix-dispatcher-with-default-values branch from 6c227f5 to e14b8e8 Compare January 29, 2023 05:27
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fgmacedo fgmacedo merged commit cb28828 into develop Jan 29, 2023
@fgmacedo fgmacedo deleted the macedo/fix-dispatcher-with-default-values branch January 29, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant