Skip to content

docs: add explanation for action return values#378

Merged
fgmacedo merged 2 commits intofgmacedo:developfrom
iamgodot:doc
Mar 20, 2023
Merged

docs: add explanation for action return values#378
fgmacedo merged 2 commits intofgmacedo:developfrom
iamgodot:doc

Conversation

@iamgodot
Copy link
Copy Markdown
Contributor

@iamgodot iamgodot commented Mar 20, 2023

Closes #377 .

@iamgodot
Copy link
Copy Markdown
Contributor Author

#377 I kind of merged it in since it's just a very small change. @fgmacedo

Copy link
Copy Markdown
Owner

@fgmacedo fgmacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Comment thread docs/actions.md Outdated
>>> sm = ExampleStateMachine()

>>> sm.loop()
>>> ['Before loop', None, 'On loop']
Copy link
Copy Markdown
Owner

@fgmacedo fgmacedo Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line broke the automated tests.

/home/runner/work/python-statemachine/python-statemachine/docs/actions.md:370: DocTestFailure
362 ...         pass
363 ...
364 ...     def on_loop(self):
365 ...         return "On loop"
366 ...
367 
368 >>> sm = ExampleStateMachine()
369 
370 >>> sm.loop()
371 >>> ['Before loop', None, 'On loop']
Expected nothing
Got:
    ['Before loop', None, 'On loop']

Just removing the prompt >>> should fix the issue.

Suggested change
>>> ['Before loop', None, 'On loop']
['Before loop', None, 'On loop']

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I thought pre-commit would run for the doc test. Well I think we're good here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0a15aa7) 100.00% compared to head (8f58e9d) 100.00%.

❗ Current head 8f58e9d differs from pull request most recent head 8c36e9e. Consider uploading reports for the commit 8c36e9e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #378   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          976       976           
  Branches       161       161           
=========================================
  Hits           976       976           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fgmacedo fgmacedo merged commit c60f7fe into fgmacedo:develop Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A small question about docs of Actions

2 participants