fix: Multiple observers can watch the same callback#387
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #387 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 976 985 +9
Branches 161 163 +2
=========================================
+ Hits 976 985 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
fgmacedo
commented
May 5, 2023
Comment on lines
+40
to
+59
| def _build_attr_wrapper(attr: str, obj): | ||
| # if `attr` is not callable, then it's an attribute or property, | ||
| # so `func` contains it's current value. | ||
| # we'll build a method that get's the fresh value for each call | ||
| getter = attrgetter(attr) | ||
|
|
||
| def wrapper(*args, **kwargs): | ||
| return getter(obj) | ||
|
|
||
| return wrapper | ||
|
|
||
|
|
||
| def _build_sm_event_wrapper(func): | ||
| "Events already have the 'machine' parameter defined." | ||
|
|
||
| def wrapper(*args, **kwargs): | ||
| kwargs.pop("machine", None) | ||
| return func(*args, **kwargs) | ||
|
|
||
| return wrapper |
Owner
Author
There was a problem hiding this comment.
author's note: Refac extracting methods from ensure_callable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fixes #384 .
Multiple observers now can watch the same callback
we register multiple observers to the same named callback.
This works also as a regression test.
Running: