Skip to content

update a comment.#429

Merged
fgmacedo merged 1 commit intofgmacedo:developfrom
NitaiP:comment_update
May 3, 2024
Merged

update a comment.#429
fgmacedo merged 1 commit intofgmacedo:developfrom
NitaiP:comment_update

Conversation

@NitaiP
Copy link
Copy Markdown
Contributor

@NitaiP NitaiP commented May 2, 2024

I have added comments in a utility routine.

Copy link
Copy Markdown
Owner

@fgmacedo fgmacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @NitaiP !

@NitaiP
Copy link
Copy Markdown
Contributor Author

NitaiP commented May 2, 2024

@fgmacedo - Thank you for approving it. I may continue to add more docstrings/comments in the near future.

It looks like one task, Upload coverage to Codecov in python 3.12 failed. What could be the reason? Do I need to do anything from my end? Thank you.

@fgmacedo
Copy link
Copy Markdown
Owner

fgmacedo commented May 2, 2024

@fgmacedo - Thank you for approving it. I may continue to add more docstrings/comments in the near future.

It looks like one task, Upload coverage to Codecov in python 3.12 failed. What could be the reason? Do I need to do anything from my end? Thank you.

Hi @NitaiP , I saw... I tried to re-run the workflow but without success. I'm working on this, I think that this can be a change on the Codecov side from yesterday. Trying to update the upload token secret, lets see if it works.

But there's something wrong not related to this PR.

@fgmacedo
Copy link
Copy Markdown
Owner

fgmacedo commented May 2, 2024

@NitaiP can you please rebase your PR over the develop branch? I've updated the codecov action on another PR and seems to have fixed the error: #430

@NitaiP NitaiP force-pushed the comment_update branch from 3b84561 to 04e52aa Compare May 3, 2024 01:38
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NitaiP
Copy link
Copy Markdown
Contributor Author

NitaiP commented May 3, 2024

@NitaiP can you please rebase your PR over the develop branch? I've updated the codecov action on another PR and seems to have fixed the error: #430

@fgmacedo - Done. Thanks.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eb844e9) to head (04e52aa).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #429   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         1174      1174           
  Branches       166       166           
=========================================
  Hits          1174      1174           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fgmacedo fgmacedo merged commit d195b4a into fgmacedo:develop May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants