fix: Configuration.add()/discard() write through model setter for persistence#596
Merged
fix: Configuration.add()/discard() write through model setter for persistence#596
Conversation
…sistence In-place mutation of the OrderedSet returned by self.value lost state changes when the model uses a deserializing property (e.g., Django model field backed by a DB column). Each getter call returned a fresh object, the in-place mutation modified a temporary, and the model was never updated. Changed add() and discard() to create a new OrderedSet and assign via self.value = new, which calls setattr on the model. This only affects atomic_configuration_update=False (StateChart default); the atomic path was never affected. Benchmark impact: ~4-5% on parallel region events (~2µs per event), negligible vs. callback execution in the same microstep. Signed-off-by: Fernando Macedo <fernando.macedo@jusbrasil.com.br>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #596 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 5007 5008 +1
Branches 813 813
=========================================
+ Hits 5007 5008 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-place mutation of the OrderedSet returned by self.value lost state changes when the model uses a deserializing property (e.g., Django model field backed by a DB column). Each getter call returned a fresh object, the in-place mutation modified a temporary, and the model was never updated.
Changed add() and discard() to create a new OrderedSet and assign via self.value = new, which calls setattr on the model. This only affects atomic_configuration_update=False (StateChart default); the atomic path was never affected.
Benchmark impact: ~4-5% on parallel region events (~2µs per event), negligible vs. callback execution in the same microstep.