fix: render human-readable Event name in diagrams#601
Merged
Conversation
Event.name is now auto-generated as a humanized form of the id (split by _ and . separators, first word capitalized) instead of echoing the raw identifier. Explicit name= passed by the user is preserved. - Add humanize_id() in utils.py (compiled regex, shared by Event and State) - Remove redundant name= from Event call sites in factory, events, and SCXML actions so auto-generation kicks in - Use event.name in diagram labels (_format_event_names) - Update docs and tests to reflect humanized names Closes #600
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #601 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 5007 5015 +8
Branches 810 810
=========================================
+ Hits 5007 5015 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #600
Event.nameis now auto-generated as a humanized form of theid(split by_and., first word capitalized) instead of echoing the raw identifier. Explicitname=passed by the user is preserved.event.nameinstead ofevent.id.EventandStateinto a sharedhumanize_id()inutils.py(compiled regex).Before
After