Skip to content

Refactor CLI argument parsing#100

Merged
fgnass merged 4 commits intofgnass:masterfrom
WeTransferArchive:cli-commander
Aug 15, 2015
Merged

Refactor CLI argument parsing#100
fgnass merged 4 commits intofgnass:masterfrom
WeTransferArchive:cli-commander

Conversation

@gasi
Copy link
Copy Markdown
Collaborator

@gasi gasi commented Aug 15, 2015

I originally built this to support --ignore path1,path2 CLI option for #99, but then realized CLI options didn’t get passed to wrap.js, so I made the change without this. Nonetheless, this uses one of the most popular CLI argument parsers which will enable easier adding of new options in the future.

Enjoy!

/cc @aseemk

fgnass added a commit that referenced this pull request Aug 15, 2015
@fgnass fgnass merged commit 432d7f2 into fgnass:master Aug 15, 2015
@fgnass
Copy link
Copy Markdown
Owner

fgnass commented Aug 15, 2015

Awesome, I wanted to to do something similar since ages! I've added you as collaborator as well as module owner on npm. I currently don't have the time to cut a new release, so it would be rad if you cut do it.

@gasi
Copy link
Copy Markdown
Collaborator Author

gasi commented Aug 17, 2015

@fgnass Thank you for the quick reply on this, accepting my changes, and making me a collaborator — With great power comes great responsibility. 😄 I will cut a new release and push to npm 👍

@gasi gasi deleted the cli-commander branch August 17, 2015 17:49
@gasi
Copy link
Copy Markdown
Collaborator Author

gasi commented Aug 18, 2015

@fgnass I added some tests, cut 2.7.0, and published it to npm: https://github.com/fgnass/node-dev/releases/tag/2.7.0 😃

@fgnass
Copy link
Copy Markdown
Owner

fgnass commented Aug 18, 2015

@gasi thank you so much! Ignoring files was one of the most requested features from the beginning of this project. I didn't like the idea in the first place because it somehow violates node-dev's zero-conf philosophy but I don't see any better solution for universal/isomorphic apps. I'm really glad you jumped in to help me maintain this project. Thanks again for your awesome work.

@aseemk
Copy link
Copy Markdown
Contributor

aseemk commented Aug 18, 2015

Woot @gasi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants