This repository was archived by the owner on Aug 11, 2020. It is now read-only.
34 resolve todos #44
Merged
34 resolve todos #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both types are required by the CertificateObtainer package. Thus, they have to be defined in the acme and not the acmeclient package. The acmeclient merely contains an (currently the only) implementaion of CertificateObtainer.
With this commit acmeclient.HTTP01Solver now exposes a Handler function which creates an http.Handler which serves the ACME challenge. This leads to a gread reduction of code while still being agnostic to the used HTTP router.
This uncovered a hole lot of problems with the tests which are fixed now as well.
The name acme.Client clashed with acmeclient.Client. Both meant differnt things. By renaming acme.Client to acme.User the distinction gets clearer.
fhofherr
force-pushed
the
34-resolve-todos
branch
from
65f4f24 to
3556f36
Compare
fhofherr
commented
Oct 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.