Skip to content

Changing FIA-API vesuvio script to allow summing multiple runs#596

Merged
Pasarus merged 10 commits intomainfrom
vesuvio_sum_multiple_runs
Feb 3, 2026
Merged

Changing FIA-API vesuvio script to allow summing multiple runs#596
Pasarus merged 10 commits intomainfrom
vesuvio_sum_multiple_runs

Conversation

@esmith1729
Copy link
Copy Markdown
Contributor

@esmith1729 esmith1729 commented Jan 28, 2026

Closes #587

Description

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.26%. Comparing base (55818c9) to head (80c7693).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   96.25%   96.26%   +0.01%     
==========================================
  Files          48       48              
  Lines        1895     1903       +8     
==========================================
+ Hits         1824     1832       +8     
  Misses         71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VESUVIO script transform to support multiple run numbers by turning list inputs into the correct Mantid-style runno string, and it adds tests to cover the new behaviors.

Changes:

  • Extend VesuvioTransform.apply to accept job.inputs["runno"] as either a scalar or a list and convert lists into either a contiguous range string ("start-end") or a comma-separated list string ("a,b,c").
  • Preserve existing behavior for single run numbers (string or scalar) by normalizing everything through a computed runno_str.
  • Add three new tests in test_vesuvio_transforms.py to validate contiguous multi-run lists, non-contiguous multi-run lists, and single-element lists.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
fia_api/scripts/transforms/vesuvio_transform.py Implements runno normalization logic to handle lists of run numbers, emitting either range or comma-separated strings and wiring this into the existing transform loop.
test/scripts/transforms/test_vesuvio_transforms.py Adds unit tests verifying that VESUVIO transforms produce the correct runno line for contiguous lists, non-contiguous lists, and single-element lists, plus existing single-run behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread fia_api/scripts/transforms/vesuvio_transform.py
Pasarus
Pasarus previously approved these changes Feb 3, 2026
@Pasarus Pasarus merged commit 3afe331 into main Feb 3, 2026
10 checks passed
@Pasarus Pasarus deleted the vesuvio_sum_multiple_runs branch February 3, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VESUVIO: Handle rule summation for the transformation

3 participants