Changing FIA-API vesuvio script to allow summing multiple runs#596
Merged
Changing FIA-API vesuvio script to allow summing multiple runs#596
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 96.25% 96.26% +0.01%
==========================================
Files 48 48
Lines 1895 1903 +8
==========================================
+ Hits 1824 1832 +8
Misses 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s/FIA-API into vesuvio_sum_multiple_runs
…s/FIA-API into vesuvio_sum_multiple_runs
There was a problem hiding this comment.
Pull request overview
This PR updates the VESUVIO script transform to support multiple run numbers by turning list inputs into the correct Mantid-style runno string, and it adds tests to cover the new behaviors.
Changes:
- Extend
VesuvioTransform.applyto acceptjob.inputs["runno"]as either a scalar or a list and convert lists into either a contiguous range string ("start-end") or a comma-separated list string ("a,b,c"). - Preserve existing behavior for single run numbers (string or scalar) by normalizing everything through a computed
runno_str. - Add three new tests in
test_vesuvio_transforms.pyto validate contiguous multi-run lists, non-contiguous multi-run lists, and single-element lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fia_api/scripts/transforms/vesuvio_transform.py | Implements runno normalization logic to handle lists of run numbers, emitting either range or comma-separated strings and wiring this into the existing transform loop. |
| test/scripts/transforms/test_vesuvio_transforms.py | Adds unit tests verifying that VESUVIO transforms produce the correct runno line for contiguous lists, non-contiguous lists, and single-element lists, plus existing single-run behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pasarus
requested changes
Feb 2, 2026
Pasarus
approved these changes
Feb 3, 2026
Pasarus
previously approved these changes
Feb 3, 2026
Pasarus
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #587
Description