Skip to content

feat: Ec2 2023 section9 sls #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mortenengen merged 45 commits into from
Jan 21, 2024
Merged

feat: Ec2 2023 section9 sls #10

mortenengen merged 45 commits into from
Jan 21, 2024

Conversation

@aperezcaldentey
Copy link
Collaborator

@aperezcaldentey aperezcaldentey commented Jan 13, 2023

First partial version of Section 9 or FprEN 1992-1-1:2022

mortenengen and others added 20 commits December 13, 2022 21:01
@mortenengen @talledodiego
Draft initial structure for the concrete class
2e70179 
Co-authored-by: talledodiego <38036285+talledodiego@users.noreply.github.com>
@mortenengen
Update docstring of base material
b8f67bb
@DanielGMorenaFhecor
minimum reinforcement areas functions
c299dcc
@aperezcaldentey
init ec2_2023
8a6bd46
@DanielGMorenaFhecor
raise ValueError test functions for min area
59a04f5
@DanielGMorenaFhecor
crack_min_steel_without_direct_calculation
b7167aa
@DanielGMorenaFhecor
Commit
7189d31
@DanielGMorenaFhecor
crack without direct calculation tests
4a0fcfb
@DanielGMorenaFhecor
adjusted bond strength
84c0140
@DanielGMorenaFhecor
hc_eff_concrete_tension formulation and testing
e0f1baa
@DanielGMorenaFhecor
requiremets.txt updated
f2cbb49
@DanielGMorenaFhecor
rho_p_eff
333dcbe
@DanielGMorenaFhecor
kt load duration
59f1198
@DanielGMorenaFhecor
strain diff formula
34d85d2
@aperezcaldentey
First partial version of Section 9 of FprEN 1992-1-1:2022
4db1358
@DanielGMorenaFhecor
chapter completed
a8ab129
@DanielGMorenaFhecor
imports and renamed functions
ce4e432
@DanielGMorenaFhecor
removed duplicate file
938c0f5
@DanielGMorenaFhecor
removed testing file
6ba6dc9
@DanielGMorenaFhecor
test renaming and docstring corrections
a9c9263
@mortenengen mortenengen deleted the branch fib-international:dev January 31, 2023 19:37
@mortenengen mortenengen reopened this Jan 31, 2023
@mortenengen
Copy link
Member

mortenengen commented Jan 31, 2023

I am sorry. I accidentally closed the PR when I deleted the branch in #7...

@mortenengen mortenengen changed the base branch from concrete-class to dev March 8, 2023 19:47
@mortenengen mortenengen changed the title Ec2 2023 section9 sls feat: Ec2 2023 section9 sls Mar 8, 2023
@DanielGMorenaFhecor DanielGMorenaFhecor self-requested a review May 8, 2023 10:23
DanielGMorenaFhecor
DanielGMorenaFhecor requested changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@DanielGMorenaFhecor DanielGMorenaFhecor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Please, take a look at the comments and tell me if you have any suggestion!

structuralcodes/codes/ec2_2023/__init__.py
Copy link
Collaborator

@DanielGMorenaFhecor DanielGMorenaFhecor May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, define your public API under the all field. Please, take as an example this file:
https://github.com/DanielGMorenaFhecor/structuralcodes/blob/ec_2004_crack_control/structuralcodes/codes/ec2_2004/init.py

@DanielGMorenaFhecor DanielGMorenaFhecor mentioned this pull request May 26, 2023
Merged
DanielGMorenaFhecor
DanielGMorenaFhecor reviewed May 26, 2023
View reviewed changes
@mortenengen mortenengen linked an issue Sep 26, 2023 that may be closed by this pull request
EC2 2023: Crack width calculations #6
Closed
1 task
DanielGMorenaFhecor
DanielGMorenaFhecor requested changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@DanielGMorenaFhecor DanielGMorenaFhecor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I think that still some Docstrings are missing (my fault, as I did not realized the last time). Please, tell my if you want me to add them and I'll do it 👍

@mortenengen mortenengen mentioned this pull request Nov 7, 2023
Open
1 task
@mortenengen mortenengen linked an issue Nov 7, 2023 that may be closed by this pull request
EC2 2023: Deflection control #52
Open
1 task
@DanielGMorenaFhecor
Copy link
Collaborator

DanielGMorenaFhecor commented Dec 18, 2023

I have just updated some changes so there are no more conflicts with the most recent dev branch changes! Nice work!

@DanielGMorenaFhecor
Copy link
Collaborator

DanielGMorenaFhecor commented Dec 26, 2023 •
edited
Loading

I have just reviewed the code so it is aligned with the typing practices we specified in our last message!

With this, I think we may merge this PR as I do not think it needs further revisions. What do you think @mortenengen and @aperezcaldentey ?

@mortenengen
Copy link
Member

mortenengen commented Dec 26, 2023

Great @DanielGMorenaFhecor! I will have a look and merge if no further changes are required.

@mortenengen mortenengen merged commit de690c3 into fib-international:dev Jan 21, 2024
@DanielGMorenaFhecor DanielGMorenaFhecor deleted the EC2_2023_Section9_SLS branch July 23, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielGMorenaFhecor DanielGMorenaFhecor DanielGMorenaFhecor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

PR tracker
Status: Done 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EC2 2023: Deflection control EC2 2023: Crack width calculations

3 participants

@aperezcaldentey @mortenengen @DanielGMorenaFhecor